Fix Replay Crash at CreateSwapChainForComposition #2017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI gfxreconstruct build queued with queue ID 368831. |
|
CI gfxreconstruct build # 6042 running. |
|
CI gfxreconstruct build # 6042 failed. |
|
This PR is good to me. It failed on our CI test, but the error was from gfxr code. It was fixed by this PR #2016. Please rebase this PR, and it will start test again. Thank you. |
Gfxr replay redirect CreateSwapChainForComposition to CreateSwapChainForHwnd. But CreateSwapChainForComposition don't have DXGI_SWAP_CHAIN_FULLSCREEN_DESC parameter. So that the replay should handle the case.
JerryAMD
force-pushed
the
dev-jerry-createswapchain
branch
from
d190c3c to
fe6ac6b
Compare
|
CI gfxreconstruct build queued with queue ID 375415. |
|
CI gfxreconstruct build # 6104 running. |
|
CI gfxreconstruct build # 6104 passed. |
locke-lunarg
approved these changes
Feb 19, 2025
|
It's good to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gfxr replay redirect CreateSwapChainForComposition to CreateSwapChainForHwnd. But CreateSwapChainForComposition don't have DXGI_SWAP_CHAIN_FULLSCREEN_DESC parameter. So that the replay should handle the case.